Cache loaded repos in ProvisioningContext #517
Conversation
Test Results 375 files ±0 375 suites ±0 47m 54s ⏱️ +59s For more details on these failures, see this check. Results for commit 5bc1d2d. ± Comparison against base commit 385d266. ♻️ This comment has been updated with latest results. |
|
I guess this same problem doesn't arise for ProvisioningContext.getLoadedArtifactRepositories(IProgressMonitor)? One concern I have here is that one can call org.eclipse.equinox.p2.engine.ProvisioningContext.setMetadataRepositories(URI...) in the API and result of getLoadedMetadataRepositories depends on that value so probably it would be most proper to clear the cache when that setter is called. |
|
The ProvisionContext is kind of messy... e.g. it says
in fact the artifact repositories are only loaded fully when the metadata is queried and so on. Of course this "distinct lifecycle" is no where described :-\ |
laeubi
force-pushed
the
cahce_loaded_repos
branch
from
3f2f8ec
to
1436f0b
Compare
laeubi
force-pushed
the
cahce_loaded_repos
branch
2 times, most recently
from
5b126d4
to
85b0b03
Compare
Currently if fetching updates the provision context is queried multiple times leading to the repositories loaded multiple times, even though this is usually faster as repo are cached this still produces unnecessary workload, especially if there is one failed repository it will be tried to be loaded over and over again. This now caches the repositories loaded on first access to speed that up.
Currently ProvisioningContextTest.testFollowHelpsResolve() assumes it can modify the context repositories after using the context but this is not valid according to API.
HannesWell
force-pushed
the
cahce_loaded_repos
branch
from
85b0b03
to
5bc1d2d
Compare
Currently if fetching updates the provision context is queried multiple times leading to the repositories loaded multiple times, even though this is usually faster as repo are cached this still produces unnecessary workload, especially if there is one failed repository it will be tried to be loaded over and over again.
This now caches the repositories loaded on first access to speed that up.